Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add step for multiple cluster MD devices #425

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Conversation

tahliar
Copy link
Collaborator

@tahliar tahliar commented Jan 15, 2025

PR creator: Description

Added a step for cloning and adding constraints for multiple cluster MD devices.

PR creator: Are there any relevant issues/feature requests?

  • bsc#1235513
  • jsc#DOCTEAM-1660

PR creator: Which product versions do the changes apply to?

When opening a PR, check all versions of the documentation that your PR applies to.

  • SLE-HA 15
    • 15 next (current main, no backport necessary)
    • 15 SP6
    • 15 SP5
    • 15 SP4
    • 15 SP3
    • 15 SP2
  • SLE-HA 12
    • 12 SP5

PR reviewer only: Have all backports been applied?

The doc team member merging your PR will take care of backporting to older documents.
When opening a PR, do not set the following check box.

  • all necessary backports are done

bsc#1235513
jsc#DOCTEAM-1660
@tahliar
Copy link
Collaborator Author

tahliar commented Jan 15, 2025

image

Copy link
Contributor

@gao-yan gao-yan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clear. Nice work, @tahliar !

<screen>&prompt.crm.conf;<command>crm configure clone cl-raider1 raider1 meta interleave=true</command>
&prompt.crm.conf;<command>crm configure clone cl-raider2 raider2 meta interleave=true</command>
&prompt.crm.conf;<command>crm configure colocation col-cmd-with-dlm inf: ( cl-raider1 cl-raider2 ) cl-storage</command>
&prompt.crm.conf;<command>crm configure order o-dlm-before-cmd Mandatory: cl-storage ( cl-raider1 cl-raider2 )</command></screen>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing is, for the case here with multiple Raid1 instances, the resource group g-storage would end up having/needing a single resource dlm, right? @zzhou1?

Practically it's not an issue even if so. But for the constraints in here, would it make more sense to reference the cl-dlm previously defined in the "DLM" chapter rather than cl-storage?

I can see the "OCFS2" chapter demonstrates the case with a single Filesystem instance where the g-storage from the previous "DLM" chapter is inherited and used:

https://documentation.suse.com/sle-ha/15-SP5/html/SLE-HA-all/cha-ha-ocfs2.html#pro-ocfs2-mount-cluster

, and the case with multiple Filesystem instances where the cl-dlm from the previous "DLM" chapter is inherited and necessary constraints are used:

https://documentation.suse.com/sle-ha/15-SP5/html/SLE-HA-all/cha-ha-ocfs2.html#pro-ocfs2-mount-multiple

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're right, it makes sense to use the non-grouped cl-dlm for these multi-resource constraints (after all, I added cl-dlm for precisely this purpose for OCFS2, then promptly forgot about it for cLVM and Cluster MD 😅).

I can change it here and in the cLVM procedure[1] unless Roger objects.

[1] https://documentation.suse.com/sle-ha/15-SP5/html/SLE-HA-all/cha-ha-clvm.html#pro-ha-clvm-rsc-lvm-activate

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarification, @tahliar !

For cLVM, lvmlockd primitive is added to the g-storage group besides dlm to be cloned together:

https://documentation.suse.com/sle-ha/15-SP5/html/SLE-HA-all/cha-ha-clvm.html#pro-ha-clvm-rsc-lvmlockd

In that case, the procedure seems sensible to use g-storage.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with Yan! Using cl-dlm is more precisely here for Cluster MD.

@tahliar
Copy link
Collaborator Author

tahliar commented Jan 22, 2025

@gao-yan I've updated the step a bit. Let me know what you think :)

image

Copy link
Contributor

@gao-yan gao-yan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good. Thanks, @tahliar !

Copy link
Contributor

@dariavladykina dariavladykina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tahliar tahliar merged commit 0f99bfd into main Jan 24, 2025
4 checks passed
@tahliar tahliar deleted the DOCTEAM-1660-multiple-raid branch January 24, 2025 03:40
tahliar added a commit that referenced this pull request Jan 24, 2025
* Add step for multiple cluster MD devices

bsc#1235513
jsc#DOCTEAM-1660

* Update from tech review
tahliar added a commit that referenced this pull request Jan 24, 2025
* Add step for multiple cluster MD devices

bsc#1235513
jsc#DOCTEAM-1660

* Update from tech review
tahliar added a commit that referenced this pull request Jan 24, 2025
* Add step for multiple cluster MD devices

bsc#1235513
jsc#DOCTEAM-1660

* Update from tech review
tahliar added a commit that referenced this pull request Jan 24, 2025
* Add step for multiple cluster MD devices

bsc#1235513
jsc#DOCTEAM-1660

* Update from tech review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants