[1/x] Prepare code sprint and implement repository type detection #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixsch
force-pushed
the
detect-repo-type
branch
from
d3c93d1 to
a4ed301
Compare
felixsch
changed the title
felixsch
changed the title
|
Well Done! Your tests are still passing. |
digitaltom
reviewed
Jan 2, 2024
| logger: logger, | ||
| mirroring_base_dir: RMT::DEFAULT_MIRROR_DIR, | ||
| mirror_src: RMT::Config.mirror_src_files?, | ||
| airgap_mode: false |
There was a problem hiding this comment.
Was it a bug that we didn't set airgap_mode before?
There was a problem hiding this comment.
It defaults to to false. For the sake of being explicit we added it here
digitaltom
reviewed
Jan 2, 2024
| base_url: URI.join(repository_url), | ||
| base_dir: repository_dir, | ||
| cache_dir: repository_dir | ||
| def detect_repository_type |
There was a problem hiding this comment.
Imho the 'detect_' prefix is superfluous.
There was a problem hiding this comment.
I agree, we keep it in mind and change the naming when we switch to our new implementations!
This was referenced Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is part of our code sprint: https://trello.com/c/hU27QHob/3134-rdeb-sprint-tracker
The whole changeset is:
[1/x] Prepare code sprint and implement repository type detection
[2/x] Add debian mirroring support to RMT
Implementations in this PR:
mirror.rbintomirror/repomd.rband make CLI and everything working with the new layoutdetect_repository_type(see: https://github.com/SUSE/rmt/pull/1056/files#diff-ab471d2d1e1090f261618b78f4d678e711afb8063a7303187375a3bbe3bee075R15)The repository type is not yet used in any way and is only there for future use.
How to test this pull request:
Make sure mirroring is working as expected
$ bin/rmt-cli mirror # Expect: mirroring to work normallyTest repository type detection
Thanks for reviewing this pull request!
If you have any question please do not hesitate to approach me! 🚀