Update repo urls on sync from SCC #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digitaltom
force-pushed
the
update_repo_urls_on_scc_sync
branch
from
b2fc8f2 to
1356c65
Compare
felixsch
reviewed
Dec 21, 2023
felixsch
approved these changes
Dec 21, 2023
There was a problem hiding this comment.
lgtm 👍
Check the trailing / first!
How I reviewed this pull request:
- Synced from a local SCC setup and then changed the URL for a system and resynced to see changes applied to the corresponding row in RMT
- Checked the code for potential pitfalls
As always, if you think I missed something please let me know! 🚀
|
Please check my latest commit and merge next week if it's good! 🎄 |
digitaltom
force-pushed
the
update_repo_urls_on_scc_sync
branch
from
c0f97f1 to
1356c65
Compare
|
Well Done! Your tests are still passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please describe your change and provide as much context as possible.
Fixes # (issue)
Change Type
Please select the correct option.
Checklist
Please check off each item if the requirement is met.
rubocop.MANUAL.mdfile with any changes to the user experience.package/obs/rmt-server.changes.Other Notes
Please use this space to provide notes or thoughts to the team, such as tips on how to review/demo your changes.