Removing rails secrets facilities from RMT #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixsch
reviewed
Jan 4, 2024
josegomezr
force-pushed
the
remove_unused_secrets_yml
branch
from
6228758 to
15d45d2
Compare
josegomezr
commented
Jan 4, 2024
felixsch
reviewed
Jan 4, 2024
josegomezr
force-pushed
the
remove_unused_secrets_yml
branch
from
15d45d2 to
7a28d1d
Compare
- RMT does not use any secret facility (key derivation for singing or encrypting data), yet rails requires a valid configuration for this to boot fine. This is now removed and hardcoded a dummy secret key base in case any other component within the rails stack tries to derivate a key.
josegomezr
force-pushed
the
remove_unused_secrets_yml
branch
from
7a28d1d to
5ea6b32
Compare
felixsch
approved these changes
Jan 4, 2024
|
Well Done! Your tests are still passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RMT does not use any secret facility (key derivation for singing or encrypting data), yet rails requires a valid configuration for this to boot fine.
This is now removed and hardcoded a dummy secret key base in case any other component within the rails stack tries to derivate a key.
Further helps #1064
Change Type
Checklist
rubocop.MANUAL.mdfile with any changes to the user experience.package/obs/rmt-server.changes.Other Notes
Please use this space to provide notes or thoughts to the team, such as tips on how to review/demo your changes.