Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6/x] Mirroring nested debian structure #1070

Merged
merged 4 commits into from
Jan 29, 2024

Conversation

likhitha77
Copy link
Contributor

@likhitha77 likhitha77 commented Jan 16, 2024

This PR is part of our code sprint: https://trello.com/c/hU27QHob/3134-rdeb-sprint-tracker

The whole changeset is:

[1/5] Prepare code sprint and implement repository type detection
[2/5] Add flat debian mirroring support to RMT
[3/5] Refactor suma mirroring
[4/5] Refactor repomd mirroring
[5/5] Fixes and cleanup
[6/6] Nested debian repository support

DO NOT MERGE UNTIL COMPLETELY READY


How to test:

To test this, we need to add a custom Debian repo with a nested structure. We can use this: http://ppa.launchpadcontent.net/ondrej/nginx/ubuntu/dists/focal/


> bin/rmt-cli repos custom repos add http://ppa.launchpadcontent.net/ondrej/nginx/ubuntu/dists/focal/ debian-nested

> bin/rmt-cli mirror repository debian-nested

  • The mirror command should succeed without errors.
  • We also need to check that the contents are mirrored to the correct location.
    • Please check that all the files listed here are present in the public/repo/ondrej/nginx/ubuntu/dists/focal path.
    • The pool directory contents must be present within the public/repo/ondrej/nginx/ubuntu/pool path

Additional check : Running the mirror command again should not throw any errors.

@likhitha77 likhitha77 added WIP Work in progress, do not merge. On hold Issue being evaluated labels Jan 16, 2024
Increase test coverage

Fix variable naming
Base automatically changed from refactor_mirror_cli to rmt_deb_codesprint January 29, 2024 14:56
@ngetahun ngetahun merged commit 9df0b61 into rmt_deb_codesprint Jan 29, 2024
@ngetahun ngetahun deleted the handle-nested-debian branch January 29, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
On hold Issue being evaluated WIP Work in progress, do not merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants