Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable catch timeout message for BV pipelines #1079

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

maximenoel8
Copy link
Contributor

@maximenoel8 maximenoel8 commented Jan 18, 2024

What does this PR

Use the new controller variable created in uyuni-project/sumaform#1465 to enable the catch timeout mechanism during BV pipelines.

@maximenoel8 maximenoel8 requested a review from a team January 18, 2024 01:03
@srbarrios
Copy link
Member

srbarrios commented Jan 18, 2024

To have this PR working, we first need to merge the other sumaform PR.
Once is merged, let's try to re-trigger this test:

╷
│ Error: Unsupported argument
│ 
│   on main.tf line 1362, in module "controller":
│ 1362:   catch_timeout_message = true
│ 
│ An argument named "catch_timeout_message" is not expected here.
╵

Copy link
Member

@srbarrios srbarrios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But first, let's merge the sumaform PR, and re-trigger the GH check to have it green.

@maximenoel8 maximenoel8 merged commit b4e2234 into SUSE:master Jan 18, 2024
1 check passed
@maximenoel8 maximenoel8 deleted the enable_catch_timeout_bv branch January 18, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants