Add the Salt bundle to all minions in the 5.0 BV #1115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dominik Gedon <[email protected]>
ktsamis
approved these changes
Feb 9, 2024
vandabarata
approved these changes
Feb 9, 2024
NamelessOne91
approved these changes
Feb 9, 2024
Bischoff
approved these changes
Feb 9, 2024
|
Agreed. But that is something for the future, when we only use the Salt bundle everywhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://github.com/uyuni-project/sumaform/blob/master/README_TESTING.md#using-salt-bundle-venv-salt-minion-in-head-and-uyuni, we should use the Salt bundle for all minions on HEAD. Pablo confirmed this in Slack.
I am not 100 % sure if this will work for the SLE Micro 5.x minions and the new s390 ones.