fix: detect identity reset by listening to cross-signing key changes - #1258
Merged
Merged
Conversation
7w1
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the server/IdP resets identity, the Matrix SDK fires CryptoEvent.KeysChanged, but the client only re-evaluated verification status on CryptoEvent.DevicesUpdated. So after a reset the client kept showing "Verified" and never surfaced the unverified state.
Adds useCrossSigningKeysChange (mirroring useDeviceListChange) and wires it into both verification hooks so status and unverified-device count re-evaluate on key changes. The existing unverified banner and Devices page then reflect the reset.
Fixes #1255
Type of change
Checklist:
AI disclosure: