Skip to content

fix: detect identity reset by listening to cross-signing key changes - #1258

Merged
7w1 merged 1 commit into
SableClient:devfrom
eleboucher:fix/detect-identity-reset-1255
Jul 23, 2026
Merged

fix: detect identity reset by listening to cross-signing key changes#1258
7w1 merged 1 commit into
SableClient:devfrom
eleboucher:fix/detect-identity-reset-1255

Conversation

@eleboucher

@eleboucher eleboucher commented Jul 23, 2026

Copy link
Copy Markdown
Member

Description

When the server/IdP resets identity, the Matrix SDK fires CryptoEvent.KeysChanged, but the client only re-evaluated verification status on CryptoEvent.DevicesUpdated. So after a reset the client kept showing "Verified" and never surfaced the unverified state.
Adds useCrossSigningKeysChange (mirroring useDeviceListChange) and wires it into both verification hooks so status and unverified-device count re-evaluate on key changes. The existing unverified banner and Devices page then reflect the reset.

Fixes #1255

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

AI disclosure:

  • Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).
  • Fully AI generated (explain what all the generated code does in moderate detail).

@eleboucher
eleboucher requested review from 7w1 and hazre as code owners July 23, 2026 19:38
@7w1 7w1 added the internal label Jul 23, 2026
@7w1
7w1 added this pull request to the merge queue Jul 23, 2026
Merged via the queue into SableClient:dev with commit 27a8a7f Jul 23, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resetting identity with OIDC/SSO doesn't work

2 participants