feat(linux): make a wry build - #1852
Open
eleboucher wants to merge 4 commits into
Open
Conversation
Stock WebKitGTK ships without ENABLE_WEB_RTC on most distros, so wry Linux builds cannot place calls. Bundle the portable runtime built by the webkitgtk-webrtc pipeline next to the binary instead of relying on the host. scripts/webkit mirrors scripts/cef: fetch the pinned artifact, stage it into webkit/ beside the binary, and package deb/rpm/AppImage from there. build.rs adds the matching rpath and main.rs points the helper processes and GStreamer at the bundle, all inert when it is absent. copy-libs.sh refuses a runtime built without relocatable-exec-path.patch or with a glibc floor above the host's, since both fail silently at runtime. The CI job builds and uploads wry bundles as artifacts only; CEF stays the shipped Linux path.
Points at run 13100, the first portable build carrying the relocation patch. fetch.sh could never have worked: node wrote the manifest fields without a trailing newline, so read returned 1 at EOF and set -e killed the script before it printed anything. Every earlier test had bypassed fetch.sh via SABLE_WEBKIT_RUNTIME_DIR.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…time Setting only GST_PLUGIN_SYSTEM_PATH_1_0 left GST_PLUGIN_PATH_1_0 unset, so the host-probing block below filled it with /usr/lib/gstreamer-1.0. Those plugins then loaded against the bundle's older GStreamer core and failed on missing symbols, and one pulled in libsoup2 alongside WebKit's libsoup3, aborting the web process and leaving the window blank. Also drops the WebKit runtime cache step. CodeQL flagged it as cache poisoning reachable from workflow_dispatch, and caching a binary runtime we then ship is exactly the wrong thing to key on a file hash. The artifact is a 131 MB download that takes seconds.
Derived by auditing the bundled runtime inside Ubuntu, Debian and Fedora containers with a desktop package set, rather than assuming. The engine needs libXtst, libXScrnSaver, libatomic, harfbuzz-icu, nghttp2, rsvg, psl, tasn1, wayland-client/egl and xcb from the host, and none of them were declared. Also re-pins the runtime at run 13112.
Contributor
|
Per https://blogs.igalia.com/webkit/blog/2026/wip-71/ This should then also use webkitgtk compiled with a libwebrtc backend going forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #
Type of change
Checklist:
AI disclosure: