feat(message): copy and save message images and link actions in the c… - #1967
Open
Th-Underscore wants to merge 1 commit into
Open
feat(message): copy and save message images and link actions in the c…#1967Th-Underscore wants to merge 1 commit into
Th-Underscore wants to merge 1 commit into
Conversation
Th-Underscore
force-pushed
the
feat/message-image-actions
branch
from
August 27, 2026 03:14
fd83de7 to
963f1ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Context-menu additions for messages:
target="_blank"anchor click aswindow.opendoesn't route to the system browser from Sable's desktop webview.The zoom-in viewer's own Save As picks up the same filename/extension improvements, keeping both paths consistent.
Tested on the desktop app, Ubuntu 24.04.
Type of change
Checklist:
.changesetAI disclosure:
I designed and directed the features and tested them in the GUI; the code itself was AI-generated.
Copy/Save reuse the existing zoom-in primitives (
copyImageToClipboard,downloadMedia,saveFileToDevice) factored into small tested pure helpers (downloadMessageImage,resolveImageSaveFilename). Image detection isclosest('[data-message-attachment], img'), so any image works while encrypted attachments keep their decrypt path. Filename resolution lives in$utils/download.tsalongside the existing sanitizer, with MIME-aware extensions derived from the downloaded blob's actual type instead of possibly-absent metadata. Clipboard failures throw so the caller can toast instead of failing silently.