Skip to content

Conversation

@thanay-sisir
Copy link
Contributor

  • Previous implementation hardcoded Unix-style separators and could write \ into zip entries on Windows, breaking extraction and structure.
  • ZIP specification requires / inside archives; this fix enforces that across all platforms.

@thanay-sisir
Copy link
Contributor Author

@lukedarlow any reviews over this luke..?

Copy link
Collaborator

@lukedarlow lukedarlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the OTHER PRs changes in models/ctm.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants