Skip to content

Commit

Permalink
Latest DoD; git ignores jsconfig.json (#25)
Browse files Browse the repository at this point in the history
- Updated PULL_REQUEST_TEMPLATE with latest Definition of Done.
- Removed + git ignores lwc/jsconfig.json.
  • Loading branch information
spelak-salesforce authored Feb 2, 2021
1 parent 8c98c0e commit b2accf5
Show file tree
Hide file tree
Showing 3 changed files with 81 additions and 76 deletions.
20 changes: 20 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,23 @@

# Issues Closed

# New Metadata

# Deleted Metadata

# Definition of Done

Refer to [Definition of Done](https://salesforce.quip.com/9P7hAOPHJJyU) to see any additional details for the items below:

- [ ] Any net new LWC work has JEST test coverage 50% or above
- [ ] Default Sa11y tests pass for all LWC components
- [ ] 🔒 Secure both Front-end (LWC) & back-end (Apex) as necessary
- [ ] 🔑 Grant users access in Permission Sets (Object, Field, Apex Class) as necessary
- [ ] Link the pull request and work item by PR comment and Chatter post respectively, e.g. GUS: [W-0000000: Work Name]()
- [ ] Make sure that ACs are updated (if any gaps)
- [ ] **All acceptance criteria have been met**
- [ ] Developer
- [ ] Code Reviewer
- [ ] Pull Request contains draft release notes
- [ ] Labels, help text, and customer facing messages are reviewed by Docs
- [ ] QE story level testing completed
105 changes: 61 additions & 44 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,49 +1,66 @@
# This file is used for Git repositories to specify intentionally untracked files that Git should ignore.
# If you are not using git, you can delete this file. For more information see: https://git-scm.com/docs/gitignore
# For useful gitignore templates see: https://github.com/github/gitignore

# Salesforce cache
.sfdx/
.localdevserver/

# LWC VSCode autocomplete
**/lwc/jsconfig.json

# LWC Jest coverage reports
coverage/

# Logs
logs
*.log
npm-debug.log*
yarn-debug.log*
yarn-error.log*
test_results.json
test_results.xml

# Node cache
node_modules/
.node_hash

# Eslint cache
.eslintcache

# MacOS system files
.DS_Store
.appcloud
.externalToolBuilders
.project
.settings
build.properties
salesforce.schema
Referenced Packages
/destructiveChanges.xml
/admin_profile
/browser_tests
/uninstall
/uninstallsrc
/installdeploy
/installedPackages
/org_unpackaged

# Windows system files
Thumbs.db
ehthumbs.db
[Dd]esktop.ini
$RECYCLE.BIN/

# CCI
.cci
/src.orig
/unpackaged/*/*/*.zip
/unpackaged/namespaced_zipped
/unpackaged/zipped
/unpackaged_stage
/packaged
/test_results.json
/test_results.xml
/test_results_junit.xml
/venv
.*.swp
/src

# Python
*.pyc
__pycache__
venv
.python_hash
.coverage
htmlcov

# Robot Framework results
robot/**/results/

# Editors
*.sublime-project
*.sublime-workspace
**/.sfdx/
**/.vscode/
**/.idea/
/config/
log.html
output.xml
report.html
*.png
testdata/dev_org/test_data.db
*.db
*.db
testdata/dev_org/test_data.db
.pmdCache
.localdevserver
.cci
node_modules/
package-lock.json
package.json
.prettierrc
.vscode
.vscode.bak
.idea
.project
.settings

# Research and Development scripts
/test.apex
32 changes: 0 additions & 32 deletions force-app/main/default/lwc/jsconfig.json

This file was deleted.

0 comments on commit b2accf5

Please sign in to comment.