fix(backend): validate additional UTxOs#257
Open
wolf31o2 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens backend transaction evaluation by validating “additional UTxOs” before they’re converted into backend-specific wire formats, explicitly rejecting both nil and typed-nil interface values (for TransactionInput / TransactionOutput) to avoid panics and confusing downstream failures.
Changes:
- Added
backend.ValidateAdditionalUtxo(and a typed-nil-aware helper) to ensure additional UTxOs have both input and output populated. - Enforced additional-UTxO validation in Ogmios conversion (
commonUtxoToShared) and Blockfrost evaluation/request building. - Added regression tests for both Ogmios and Blockfrost to confirm malformed additional UTxOs are rejected early (and before network requests for Blockfrost).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| backend/base.go | Adds shared validation helpers to reject missing/typed-nil UTxO fields. |
| backend/blockfrost/blockfrost.go | Validates additional UTxOs before evaluation and before building /evaluate/utxos request items. |
| backend/blockfrost/blockfrost_test.go | Adds regression coverage for rejecting malformed additional UTxOs and ensuring no HTTP request is made. |
| backend/ogmios/ogmios.go | Validates resolved UTxOs before converting them to Ogmios shared wire format. |
| backend/ogmios/ogmios_test.go | Adds regression coverage for rejecting malformed additional UTxOs (including typed-nil cases). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing