Skip to content

Addressing PR comments#146

Merged
Sans3108 merged 6 commits into
masterfrom
copilot/update-npm-publish-action
Apr 4, 2026
Merged

Addressing PR comments#146
Sans3108 merged 6 commits into
masterfrom
copilot/update-npm-publish-action

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 4, 2026 •
edited by Claude AI
Loading

No description provided.

@Sans3108
Update npm publish workflow to use Trusted Publishing (OIDC), bump al…
9aee728 
…l actions, and add publishing docs

Agent-Logs-Url: https://github.com/Sans3108/DDNet/sessions/3f88e6bd-af8e-4c81-97d7-7e069b4ba057

Co-authored-by: Sans3108 <39863198+Sans3108@users.noreply.github.com>
github-advanced-security[bot]
github-advanced-security AI found potential problems Apr 4, 2026
View reviewed changes
Comment thread .github/workflows/npm-publish.yml Fixed
Comment thread .github/workflows/prettier.yml Fixed
Copilot AI requested a review from Sans3108 April 4, 2026 07:48
@Claude @Sans3108
Pin pnpm/action-setup to commit SHA for security
90c4931 
Agent-Logs-Url: https://github.com/Sans3108/DDNet/sessions/0533fb26-551c-4f10-a882-6b13145c394b

Co-authored-by: Sans3108 <39863198+Sans3108@users.noreply.github.com>
@Sans3108
Copy link
Copy Markdown
Owner

Sans3108 commented Apr 4, 2026

@claude[agent] Review and refine the pr, fix the other agent's code if needed

@Claude
Copy link
Copy Markdown
Contributor

Claude AI commented Apr 4, 2026

@claude[agent] Review and refine the pr, fix the other agent's code if needed

Reviewed and refined the PR. Fixed issues in 075b230:

Issues found and fixed:

  1. prettier.yml was accidentally reverted - Restored the complete workflow with proper action versions, pnpm caching, and frozen-lockfile
  2. Missing pnpm version specification - Added version: 9 to pnpm/action-setup in both workflows (required parameter)

Verification:

  • Both workflow files validated as proper YAML
  • All actions properly pinned to commit SHAs for security
  • pnpm version 9 matches lockfileVersion: '9.0' in pnpm-lock.yaml
  • All changes from previous commits preserved and enhanced

@Claude Claude AI changed the title Update npm publish workflow to use Trusted Publishing (OIDC) and bump actions Addressing PR comments Apr 4, 2026
@Sans3108
Copy link
Copy Markdown
Owner

Sans3108 commented Apr 4, 2026

@claude[agent] Either remove or edit the publishing markdown file to generalize it, leave out my personal details

@Claude
Copy link
Copy Markdown
Contributor

Claude AI commented Apr 4, 2026

@claude[agent] Either remove or edit the publishing markdown file to generalize it, leave out my personal details

Generalized PUBLISHING.md in 17986a3. Replaced all personal details with placeholders:

  • Package name → generic "your package"
  • npm URLs → template format with <your-package-name>
  • GitHub username/repo → "Your GitHub username or organization" / "Your repository name"
  • Specific GitHub URLs → generic instructions

The documentation is now reusable for any project.

@Sans3108 Sans3108 marked this pull request as ready for review April 4, 2026 08:38
@Sans3108
Copy link
Copy Markdown
Owner

Sans3108 commented Apr 4, 2026

@claude[agent] Squash and merge this

@Claude
Copy link
Copy Markdown
Contributor

Claude AI commented Apr 4, 2026

@claude[agent] Squash and merge this

I don't have the ability to merge pull requests through the GitHub UI. You'll need to click the "Squash and merge" button on the GitHub PR page yourself.

All the changes are ready and pushed to the branch. The PR includes:

  • Updated GitHub Actions workflows with security best practices
  • npm Trusted Publishing (OIDC) implementation
  • Generalized documentation
  • All issues from code scanning resolved

@Claude Claude AI requested a review from Sans3108 April 4, 2026 08:43
@Sans3108 Sans3108 merged commit 845c441 into master Apr 4, 2026
5 checks passed
@Sans3108 Sans3108 deleted the copilot/update-npm-publish-action branch April 4, 2026 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Claude Claude Claude left review comments

+1 more reviewer

@Sans3108 Sans3108 Sans3108 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Sans3108 Sans3108

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Sans3108 @Claude @github-advanced-security @actions-user