Skip to content

Adjust filter view to not allow overriding #2141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pondrejk merged 1 commit into from
Oct 15, 2025
Merged

Adjust filter view to not allow overriding #2141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 1 addition & 23 deletions airgun/views/filter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,14 @@
from widgetastic.widget import (
Checkbox,
ConditionalSwitchableView,
Table,
Text,
TextInput,
View,
)
from widgetastic_patternfly import BreadCrumb
from widgetastic_patternfly4 import Pagination as PF4Pagination

from airgun.views.common import BaseLoggedInView, SatTab
from airgun.views.common import BaseLoggedInView
from airgun.widgets import (
ActionsDropdown,
MultiSelect,
PF4FilteredDropdown,
PF4MultiSelect,
Search,
Expand Down Expand Up @@ -55,8 +51,6 @@ class FilterDetailsView(BaseLoggedInView):
locator='.//div[@data-ouia-component-id="resource-type-select"]'
)
permission = PF4MultiSelect('.//div[@id="permission-duel-select"]')
override = Checkbox(id='override-check')
unlimited = Checkbox(id='filter_unlimited')
filter = TextInput(id='search')
submit = Text('//button[@data-ouia-component-id="filters-submit-button"]')

Expand All @@ -69,22 +63,6 @@ def is_displayed(self):
and self.breadcrumb.read().startswith('Edit filter for ')
)

taxonomies_tabs = ConditionalSwitchableView(reference='override')

@taxonomies_tabs.register(True)
class Taxonomies(View):
@View.nested
class locations(SatTab):
resources = MultiSelect(id='ms-filter_location_ids')

@View.nested
class organizations(SatTab):
resources = MultiSelect(id='ms-filter_organization_ids')

@taxonomies_tabs.register(False)
class NoTaxonomies(View):
pass


class FilterCreateView(FilterDetailsView):
@property
Expand Down