Skip to content

Conversation

@pondrejk
Copy link
Contributor

@pondrejk pondrejk commented Dec 9, 2025

wip, should go hand in hand with theforeman/foreman_webhooks#91

@pondrejk pondrejk self-assigned this Dec 9, 2025
@pondrejk pondrejk marked this pull request as draft December 9, 2025 13:46
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • The new locators rely heavily on specific IDs (e.g., webhookCreateModal, typeahead-select-input-event); consider whether there are more stable attributes or patterns (like data-* attributes or form structure) that would be less brittle to UI refactors.
  • Within general, the locators mix id and name attributes (name now uses id, while target_url still uses name); consider standardizing on one approach for similar fields to keep the view definition consistent and easier to maintain.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The new locators rely heavily on specific IDs (e.g., `webhookCreateModal`, `typeahead-select-input-event`); consider whether there are more stable attributes or patterns (like data-* attributes or form structure) that would be less brittle to UI refactors.
- Within `general`, the locators mix `id` and `name` attributes (`name` now uses `id`, while `target_url` still uses `name`); consider standardizing on one approach for similar fields to keep the view definition consistent and easier to maintain.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant