Skip to content

Conversation

@adamruzicka
Copy link
Contributor

@adamruzicka adamruzicka commented Oct 10, 2025

Description of changes

A change in Foreman drops the option to override filters as well as dropping the unlimited field. Those fields previously required mapping, there won't be any need for that anymore.
Also taxonomies have been removed from filters.

Upstream API documentation, plugin, or feature links

theforeman/foreman#10370

@adamruzicka adamruzicka added the No-CherryPick PR doesnt need CherryPick to previous branches label Oct 10, 2025
@adamruzicka adamruzicka marked this pull request as ready for review October 15, 2025 10:03
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Contributor

@pnovotny pnovotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhellebr lhellebr added the Do not merge Do not merge this pull request label Oct 16, 2025
@lhellebr
Copy link
Contributor

lhellebr commented Oct 16, 2025

I'll just add the PR also removes taxonomies.
Adding "Do not merge" label since the foreman PR hasn't been merged yet.

@pnovotny
Copy link
Contributor

I'll just add the PR also removes taxonomies. Adding "Do not merge" label since the foreman PR hasn't been merged yet.

The theforeman/foreman#10370 and theforeman/hammer-cli-foreman#645 PRs got just merged.
I've inspected the only PRT failure in SatelliteQE/robottelo#19899 and it looks fine (not related).
Thus, both PRs are ready to be merged.

@pnovotny pnovotny removed the Do not merge Do not merge this pull request label Oct 16, 2025
@pnovotny pnovotny merged commit c14e747 into SatelliteQE:master Oct 16, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No-CherryPick PR doesnt need CherryPick to previous branches

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants