-
Notifications
You must be signed in to change notification settings - Fork 90
Drop field mapping for Filter #1363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cc6b128 to
4409997
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pnovotny
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
I'll just add the PR also removes taxonomies. |
The theforeman/foreman#10370 and theforeman/hammer-cli-foreman#645 PRs got just merged. |
Description of changes
A change in Foreman drops the option to override filters as well as dropping the unlimited field. Those fields previously required mapping, there won't be any need for that anymore.
Also taxonomies have been removed from filters.
Upstream API documentation, plugin, or feature links
theforeman/foreman#10370