-
Notifications
You must be signed in to change notification settings - Fork 90
Remove subscription attachment methods #1377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jameerpathan111
merged 4 commits into
SatelliteQE:master
from
jeremylenz:remove-subscription-attachment-methods
Nov 11, 2025
Merged
Remove subscription attachment methods #1377
jameerpathan111
merged 4 commits into
SatelliteQE:master
from
jeremylenz:remove-subscription-attachment-methods
Nov 11, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…scription Since Simple Content Access (SCA) is now the default and only mode for all organizations, subscription attachment to activation keys and hosts is no longer supported. This removes the following methods: ActivationKey: - add_subscriptions() - remove_subscriptions() - subscriptions() HostSubscription: - path() override for add_subscriptions and remove_subscriptions - subscriptions() - add_subscriptions() - remove_subscriptions() 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
… Host This commit removes the remaining subscription attachment path references: - ActivationKey.path(): Removed add_subscriptions, remove_subscriptions, and subscriptions from path definitions - Host.path(): Removed bulk/add_subscriptions and bulk/remove_subscriptions from path definitions - Host: Removed bulk_add_subscriptions() and bulk_remove_subscriptions() methods
The HostSubscription entity was used to manage the relationship between hosts and subscriptions. Since subscription attachment is no longer supported in SCA mode, this entire entity class is obsolete and has been removed. Changes: - Removed HostSubscription class from entities.py - Removed HostSubscription from entity instantiation tests - Removed HostSubscription from required params tests - Removed test_hostsubscription() test method - Removed ActivationKey subscription method tests (add_subscriptions, remove_subscriptions, subscriptions) - Removed HostSubscription method tests (add_subscriptions, remove_subscriptions)
7df6846 to
4591c79
Compare
Remove test cases for add_subscriptions, remove_subscriptions, and subscriptions paths from test_id_and_which since these methods were removed from ActivationKey.
Contributor
|
pre-commit.ci autofix |
ColeHiggins2
approved these changes
Nov 10, 2025
LadislavVasina1
approved these changes
Nov 11, 2025
jameerpathan111
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
Since Simple Content Access (SCA) is now the default and only mode for all organizations, subscription attachment to activation keys and hosts is no longer supported in Satellite. The CLI methods were removed in SatelliteQE/robottelo#19931 and the API endpoints are being removed from Satellite.
Solution
This PR removes the subscription attachment methods from nailgun entities:
ActivationKey:
add_subscriptions()remove_subscriptions()subscriptions()HostSubscription:
path()override for add_subscriptions and remove_subscriptionssubscriptions()add_subscriptions()remove_subscriptions()Related PRs
Files changed: 1 file, 131 deletions(-)