Skip to content

Updated the assertion to align with the 'rex_snippet' var. #17088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Gauravtalreja1 merged 1 commit into from
Dec 9, 2024
Merged

Updated the assertion to align with the 'rex_snippet' var. #17088

Gauravtalreja1 merged 1 commit into from
Dec 9, 2024

Conversation

@amolpati30
Copy link
Contributor

@amolpati30 amolpati30 commented Dec 5, 2024 •
edited
Loading

The output of the variable rex_snippet has changed. For example:

  • Before: yggdrasild
  • After: $YGGDRASIL_SERVICE

The assertion has been updated accordingly to reflect this change.

@amolpati30 amolpati30 added Easy Fix :) Easiest Fix to review and quick merge request. AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing labels Dec 5, 2024
@amolpati30 amolpati30 requested a review from a team as a code owner December 5, 2024 14:18
@amolpati30 amolpati30 added the No-CherryPick PR doesnt need CherryPick to previous branches label Dec 5, 2024
@amolpati30
Copy link
Contributor Author

amolpati30 commented Dec 5, 2024

trigger: test-robottelo
pytest: tests/foreman/api/test_provisioningtemplate.py -k 'test_positive_template_check_rex_pull_mode_snippet or test_positive_template_check_rex_snippet'

@Satellite-QE
Copy link
Collaborator

Satellite-QE commented Dec 5, 2024

PRT Result

Build Number: 9544
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_provisioningtemplate.py -k test_positive_template_check_rex_pull_mode_snippet or test_positive_template_check_rex_snippet --external-logging
Test Result : ========== 6 passed, 22 deselected, 122 warnings in 720.00s (0:12:00) ==========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Dec 5, 2024
@Gauravtalreja1
Copy link
Member

Gauravtalreja1 commented Dec 6, 2024

What is Some changes have been updated and added to the assertion, could you elaborate and be specific in commit msg and PR title?

@amolpati30 amolpati30 changed the title added updated thing in assertion Updated the assertion to align with the 'rex_snippet' variable. Dec 6, 2024
@amolpati30 amolpati30 changed the title Updated the assertion to align with the 'rex_snippet' variable. Updated the assertion to align with the 'rex_snippet' var. Dec 6, 2024
@amolpati30
Copy link
Contributor Author

amolpati30 commented Dec 6, 2024

What is Some changes have been updated and added to the assertion, could you elaborate and be specific in commit msg and PR title?

Done.

Gauravtalreja1
Gauravtalreja1 approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@Gauravtalreja1 Gauravtalreja1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, just fyi this changes were introduced in PR theforeman/foreman#10340 and theforeman/foreman#10236

@Gauravtalreja1
Copy link
Member

Gauravtalreja1 commented Dec 9, 2024

@amolpati30 There is still no update in the commit message, please fix it

@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Dec 9, 2024
@Gauravtalreja1 Gauravtalreja1 added Stream Introduced in or relating directly to Satellite Stream/Master Tracker issues used just as a tracker to group multiple related issues together TestFailure Issues and PRs related to a test failing in automation and removed AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing Tracker issues used just as a tracker to group multiple related issues together labels Dec 9, 2024
@Gauravtalreja1 Gauravtalreja1 merged commit dfbde5b into SatelliteQE:master Dec 9, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

Assignees

@amolpati30 amolpati30

Labels

Easy Fix :) Easiest Fix to review and quick merge request. No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master TestFailure Issues and PRs related to a test failing in automation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@amolpati30 @Satellite-QE @Gauravtalreja1