Remove subscription entitlment hammer class methods #20121
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
chris1984
added
CLI
Gauravtalreja1
added
the
Stream
chris1984
force-pushed
the
remove-hammersubs
branch
from
4903e7c to
ac281a6
Compare
|
trigger: test-robottelo |
|
PRT Result |
Satellite-QE
added
the
PRT-Passed
| return cls.execute(cls._construct_command(options)) | ||
|
|
||
| @classmethod | ||
| def subscription_attach(cls, options=None): |
There was a problem hiding this comment.
subscription_attach is still being used at - https://github.com/SatelliteQE/robottelo/blob/master/robottelo/hosts.py#L1463
synkd
left a comment
synkd
left a comment
There was a problem hiding this comment.
One change requested. Also, please note that running new upgrade tests requires using the -n option and modifying some config settings via environment variables. I would use the following to kick off the PRT job after making the requested changes:
trigger: test-robottelo
pytest: -n 1 tests/new_upgrades/test_subscription.py
env:
ROBOTTELO_server__xdist_behavior: 'run-on-one'
ROBOTTELO_upgrade__from_version: '6.18'
ROBOTTELO_upgrade__to_version: 'stream'
|
|
||
| @pytest.fixture | ||
| def subscription_auto_attach_setup( | ||
| def subscription_setup( |
There was a problem hiding this comment.
Rather than changing the name of this fixture and continuing to use it, I think it makes more sense to test this with test_candlepin_hung_transaction inheriting the other setup fixture in this module, manifest_scenario_refresh_setup. If that passes, the subscription_setup fixture could be removed entirely.
|
@chris1984 could you please look at @synkd suggestion and update the PR |
7 participants
Problem Statement
We are going through and removing entitlement subscription info out of hammer and katello, this removes the commands in robotello
Solution
Removed the commands
Related Issues
Katello/hammer-cli-katello#1006
trigger: test-robottelo
pytest: tests/foreman/cli/test_subscription.py