-
Notifications
You must be signed in to change notification settings - Fork 131
Add coverage for bulk errata endpoints #20193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- Consider extracting the repeated bulk_applicable_errata and bulk_installable_errata calls into a small helper to reduce duplication and improve test readability.
- Add a polling or wait step after publishing and promoting the content view to ensure the new version is available before refreshing the host and asserting installability, to avoid flakiness.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider extracting the repeated bulk_applicable_errata and bulk_installable_errata calls into a small helper to reduce duplication and improve test readability.
- Add a polling or wait step after publishing and promoting the content view to ensure the new version is available before refreshing the host and asserting installability, to avoid flakiness.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
PRT Result |
The PRT failure is related to removal of |
sambible
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test looks good, lets add that second host and verify installable and applicable both are visible in the bulk API, and then we can merge.
|
|
PRT Result |
LadislavVasina1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, PRT passing
* Add coverage for bulk errata endpoints * Extend the test case with another contenthost (cherry picked from commit 86b6acd)
Problem Statement
SAT-30754 needs coverage to test bulk errata applicable and installable endpoints.
Solution
This PR proposes one.
Related Issues
https://issues.redhat.com/browse/SAT-30754
requires: SatelliteQE/nailgun#1375
PRT test Cases example