Skip to content

Conversation

@amolpati30
Copy link
Contributor

Problem Statement

The test was failing because of recent changes in hammer-cli-katello.

Solution

Updating the changes with the most recent modification.

@amolpati30 amolpati30 requested a review from a team as a code owner November 27, 2025 18:52
@amolpati30 amolpati30 added TestFailure Issues and PRs related to a test failing in automation Easy Fix :) Easiest Fix to review and quick merge request. CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.16.z 6.17.z 6.18.z Introduced in or relating directly to Satellite 6.18 labels Nov 27, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • These tests are tightly coupled to the exact JSON keys returned by hammer; consider centralizing the key names (e.g., via helper functions or constants) so that future upstream naming changes require updates in only one place instead of throughout the tests.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- These tests are tightly coupled to the exact JSON keys returned by hammer; consider centralizing the key names (e.g., via helper functions or constants) so that future upstream naming changes require updates in only one place instead of throughout the tests.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@amolpati30 amolpati30 force-pushed the Update_naming_for_Hammer_host_info branch from f7e35c3 to 70dd25d Compare November 27, 2025 18:58
@amolpati30
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/endtoend/test_cli_endtoend.py -k test_positive_cli_end_to_end

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 13625
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/endtoend/test_cli_endtoend.py -k test_positive_cli_end_to_end --external-logging
Test Result : =========== 1 passed, 3 deselected, 9 warnings in 1165.53s (0:19:25) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Nov 27, 2025
@Gauravtalreja1 Gauravtalreja1 added No-CherryPick PR doesnt need CherryPick to previous branches and removed Easy Fix :) Easiest Fix to review and quick merge request. CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.16.z 6.17.z 6.18.z Introduced in or relating directly to Satellite 6.18 labels Nov 27, 2025
@Gauravtalreja1 Gauravtalreja1 merged commit 98f0b77 into SatelliteQE:master Nov 27, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR TestFailure Issues and PRs related to a test failing in automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants