filtering out non-BMP characters from CJK string

[vijaysawant]

Problem Statement

test case test_positive_create_in_different_orgs failing for cjk parameterised string with an error
selenium.common.exceptions.WebDriverException: Message: unknown error: ChromeDriver only supports characters in the BMP

Solution

filtering out non-BMP characters is the recommended way instead of removing CJK from valid_data_list()

Related Issues

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/ui/test_product.py -k 'test_positive_create_in_different_orgs'

[vijaysawant]

trigger: test-robottelo
pytest: tests/foreman/ui/test_product.py -k 'test_positive_create_in_different_orgs'

[Satellite-QE]

PRT Result

Build Number: 13882
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_product.py -k test_positive_create_in_different_orgs --external-logging
Test Result : ========== 7 passed, 3 deselected, 81 warnings in 1759.99s (0:29:19) ===========

[sourcery-ai]

Hey there - I've reviewed your changes - here's some feedback:

• The CJK regeneration loop in filtered_datapoint uses hard-coded values for min_length (half the original length) and max_attempts (10); consider making these configurable or at least defining them as named constants to clarify the intended behavior and make future tuning easier.
• If all regeneration attempts fail and the fallback gen_string('cjk', 10) still produces mostly non-BMP characters, dataset['cjk'] may end up unexpectedly short; you might want to explicitly enforce a minimum length after the fallback or log when the code cannot generate a sufficiently long BMP-only CJK string.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The CJK regeneration loop in `filtered_datapoint` uses hard-coded values for `min_length` (half the original length) and `max_attempts` (10); consider making these configurable or at least defining them as named constants to clarify the intended behavior and make future tuning easier.
- If all regeneration attempts fail and the fallback `gen_string('cjk', 10)` still produces mostly non-BMP characters, `dataset['cjk']` may end up unexpectedly short; you might want to explicitly enforce a minimum length after the fallback or log when the code cannot generate a sufficiently long BMP-only CJK string.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[jnagare-redhat]

LGTM

[ogajduse]

I'd recommend implementing CJK generation in Fauxfactory without BMP characters first, and then follow up here in Robottelo.
omaciel/fauxfactory#129

[vsedmik]

Looks like @omaciel already implemented the change in fauxfactory 🚀

Could we use it, @vijaysawant ?