Skip to content

Conversation

@jnagare-redhat
Copy link
Contributor

@jnagare-redhat jnagare-redhat commented Dec 16, 2025

Problem Statement

During each interop test milestone, we experience numerous failures within the RH Cloud test automation.
Card : https://issues.redhat.com/browse/SAT-41010

Solution

Kept only one e2e test case for each RH Cloud functionality in interopt

Related Issues

@jnagare-redhat jnagare-redhat requested a review from a team as a code owner December 16, 2025 12:20
@jnagare-redhat jnagare-redhat added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing Stream Introduced in or relating directly to Satellite Stream/Master 6.17.z 6.18.z Introduced in or relating directly to Satellite 6.18 labels Dec 16, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • In test_sync_inventory_status you removed only @pytest.mark.pit_server but kept @pytest.mark.pit_client; if the goal is to reduce PIT coverage for interop, double‑check whether this asymmetry is intentional or if both marks should be handled consistently.
  • The PR description mentions keeping only one e2e test per RH Cloud functionality, but the changes here only adjust PIT markers; consider clarifying which single PIT‑enabled e2e tests are intended to remain and ensuring other tests have their PIT markers removed consistently across the suite.
  • test_rhcloud_global_parameters is no longer marked with any PIT markers while still constrained with run_in_one_thread; verify this test is meant to run in the broader test matrix and not just in the PIT pipeline to avoid unexpectedly lengthening general test runs.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- In `test_sync_inventory_status` you removed only `@pytest.mark.pit_server` but kept `@pytest.mark.pit_client`; if the goal is to reduce PIT coverage for interop, double‑check whether this asymmetry is intentional or if both marks should be handled consistently.
- The PR description mentions keeping only one e2e test per RH Cloud functionality, but the changes here only adjust PIT markers; consider clarifying which single PIT‑enabled e2e tests are intended to remain and ensuring other tests have their PIT markers removed consistently across the suite.
- `test_rhcloud_global_parameters` is no longer marked with any PIT markers while still constrained with `run_in_one_thread`; verify this test is meant to run in the broader test matrix and not just in the PIT pipeline to avoid unexpectedly lengthening general test runs.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@jnagare-redhat jnagare-redhat changed the title Kept only one e2e test case for each RH Cloud functionality for interopt Kept few e2e test case for each RH Cloud functionality as a part of interopt Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.17.z 6.18.z Introduced in or relating directly to Satellite 6.18 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants