Skip to content

Fix template sync over SSH on IPv6 #20552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
lpramuk wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix template sync over SSH on IPv6 #20552

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pytest_fixtures/component/templatesync.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ def git_pub_key(session_target_sat, git_port):
id = res.json()['id']
# add ssh key to known host
session_target_sat.execute(
f'ssh-keyscan -4 -t rsa -p {git.ssh_port} {git.hostname} > {key_path}/known_hosts'
f"sudo -u foreman sh -c 'ssh-keyscan -t rsa -p {git.ssh_port} {git.hostname} >> {key_path}/known_hosts'"
Copy link
Contributor Author

@lpramuk lpramuk Dec 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes three problems:

  1. -4 - dont always use ipv4, especially on ipv6
  2. sudo -u foreman ... - .ssh/known_hosts file should be owned by user foreman not root
  3. >> {key_path}/known_hosts - .ssh/known_hosts file may contain multiple entries, append new entry

)
yield
res = requests.delete(
Expand Down