Skip to content

Modify Libvirt tests to run on Libvirt-CR deployed on RHEL10 #20570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Gauravtalreja1 wants to merge 1 commit into
base: master
Choose a base branch
from
+111 −100
Open

Modify Libvirt tests to run on Libvirt-CR deployed on RHEL10 #20570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions pytest_fixtures/component/provision_libvirt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,32 @@
# Compute resource - Libvirt entities
from box import Box
from fauxfactory import gen_string
import pytest

from robottelo.config import settings
from robottelo.constants import COMPUTE_PROFILE_SMALL, FOREMAN_PROVIDERS, LIBVIRT_RESOURCE_URL

LIBVIRT_URL = LIBVIRT_RESOURCE_URL % settings.libvirt.libvirt_hostname

@pytest.fixture(scope='module')
def libvirt(request):
versions = {
'libvirt9': settings.libvirt.hostname.libvirt9,
'libvirt10': settings.libvirt.hostname.libvirt10,
Comment on lines +13 to +14
Copy link
Contributor

@amolpati30 amolpati30 Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libvirt9 and libvirt10 are not defined in the libvirt settings. Have you raised an MR for this?

Copy link
Member Author

@Gauravtalreja1 Gauravtalreja1 Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course, yes, see satellite-jenkins MR#1838, where I'm validating this changing using its Jenkins MR

}
default = versions[getattr(request, 'param', 'libvirt9')]
return Box(fqdn=default, url=LIBVIRT_RESOURCE_URL % default)


@pytest.fixture(scope='module')
def module_cr_libvirt(module_target_sat, module_org, module_location):
def module_cr_libvirt(module_target_sat, module_org, module_location, libvirt):
"""Create a Libvirt compute resource for the module."""
return module_target_sat.api.LibvirtComputeResource(
name=gen_string('alpha'),
provider=FOREMAN_PROVIDERS['libvirt'],
display_type='VNC',
organization=[module_org],
location=[module_location],
url=LIBVIRT_URL,
url=libvirt.url,
).create()


Expand All @@ -27,9 +36,9 @@ def module_libvirt_image(module_target_sat, module_cr_libvirt):


@pytest.fixture(scope='module')
def module_libvirt_provisioning_sat(module_provisioning_sat):
def module_libvirt_provisioning_sat(module_provisioning_sat, libvirt):
# Configure Libvirt CR for provisioning
module_provisioning_sat.sat.configure_libvirt_cr()
module_provisioning_sat.sat.configure_libvirt_cr(server_fqdn=libvirt.fqdn)
return module_provisioning_sat


Expand Down
55 changes: 31 additions & 24 deletions tests/foreman/api/test_computeresource_libvirt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
from wait_for import wait_for

from robottelo.config import settings
from robottelo.constants import FOREMAN_PROVIDERS, LIBVIRT_RESOURCE_URL
from robottelo.constants import FOREMAN_PROVIDERS
from robottelo.hosts import ContentHost
from robottelo.utils.datafactory import (
invalid_values_list,
Expand All @@ -32,11 +32,10 @@

pytestmark = [pytest.mark.skip_if_not_set('libvirt')]

LIBVIRT_URL = LIBVIRT_RESOURCE_URL % settings.libvirt.libvirt_hostname


@pytest.mark.e2e
def test_positive_crud_libvirt_cr(module_target_sat, module_org, module_location):
@pytest.mark.parametrize('libvirt', ['libvirt9', 'libvirt10'], indirect=True)
def test_positive_crud_libvirt_cr(module_target_sat, module_org, module_location, libvirt):
"""CRUD compute resource libvirt

:id: 1e545c56-2f53-44c1-a17e-38c83f8fe0c2
Expand Down Expand Up @@ -74,7 +73,7 @@ def test_positive_crud_libvirt_cr(module_target_sat, module_org, module_location
cr.name = new_name
cr.description = new_description
cr.display_type = new_display_type
cr.url = LIBVIRT_URL
cr.url = libvirt.url
cr.organization = [new_org]
cr.location = [new_loc]
cr.update(['name', 'description', 'display_type', 'url', 'organization', 'location'])
Expand All @@ -84,7 +83,7 @@ def test_positive_crud_libvirt_cr(module_target_sat, module_org, module_location
assert updated_cr.name == new_name
assert updated_cr.description == new_description
assert updated_cr.display_type == new_display_type
assert updated_cr.url == LIBVIRT_URL
assert updated_cr.url == libvirt.url
assert updated_cr.organization[0].id == new_org.id
assert updated_cr.location[0].id == new_loc.id
# DELETE
Expand All @@ -96,7 +95,7 @@ def test_positive_crud_libvirt_cr(module_target_sat, module_org, module_location

@pytest.mark.parametrize('name', **parametrized(valid_data_list()))
def test_positive_create_with_name_description(
name, request, module_target_sat, module_org, module_location
name, request, module_target_sat, module_org, module_location, libvirt
):
"""Create compute resources with different names and descriptions

Expand All @@ -113,14 +112,14 @@ def test_positive_create_with_name_description(
description=name,
organization=[module_org],
location=[module_location],
url=LIBVIRT_URL,
url=libvirt.url,
).create()
request.addfinalizer(compresource.delete)
assert compresource.name == name
assert compresource.description == name


def test_positive_create_with_orgs_and_locs(request, module_target_sat):
def test_positive_create_with_orgs_and_locs(request, module_target_sat, libvirt):
"""Create a compute resource with multiple organizations and locations

:id: c6c6c6f7-50ca-4f38-8126-eb95359d7cbb
Expand All @@ -133,15 +132,17 @@ def test_positive_create_with_orgs_and_locs(request, module_target_sat):
orgs = [module_target_sat.api.Organization().create() for _ in range(2)]
locs = [module_target_sat.api.Location(organization=[org]).create() for org in orgs]
compresource = module_target_sat.api.LibvirtComputeResource(
location=locs, organization=orgs, url=LIBVIRT_URL
location=locs, organization=orgs, url=libvirt.url
).create()
request.addfinalizer(compresource.delete)
assert {org.name for org in orgs} == {org.read().name for org in compresource.organization}
assert {loc.name for loc in locs} == {loc.read().name for loc in compresource.location}


@pytest.mark.parametrize('name', **parametrized(invalid_values_list()))
def test_negative_create_with_invalid_name(name, module_target_sat, module_org, module_location):
def test_negative_create_with_invalid_name(
name, module_target_sat, module_org, module_location, libvirt
):
"""Attempt to create compute resources with invalid names

:id: f73bf838-3ffd-46d3-869c-81b334b47b13
Expand All @@ -157,11 +158,13 @@ def test_negative_create_with_invalid_name(name, module_target_sat, module_org,
name=name,
organization=[module_org],
location=[module_location],
url=LIBVIRT_URL,
url=libvirt.url,
).create()


def test_negative_create_with_same_name(request, module_target_sat, module_org, module_location):
def test_negative_create_with_same_name(
request, module_target_sat, module_org, module_location, libvirt
):
"""Attempt to create a compute resource with already existing name

:id: 9376e25c-2aa8-4d99-83aa-2eec160c030e
Expand All @@ -172,7 +175,7 @@ def test_negative_create_with_same_name(request, module_target_sat, module_org,
"""
name = gen_string('alphanumeric')
cr = module_target_sat.api.LibvirtComputeResource(
location=[module_location], name=name, organization=[module_org], url=LIBVIRT_URL
location=[module_location], name=name, organization=[module_org], url=libvirt.url
).create()
request.addfinalizer(cr.delete)
assert cr.name == name
Expand All @@ -181,7 +184,7 @@ def test_negative_create_with_same_name(request, module_target_sat, module_org,
name=name,
organization=[module_org],
location=[module_location],
url=LIBVIRT_URL,
url=libvirt.url,
).create()


Expand All @@ -205,7 +208,7 @@ def test_negative_create_with_url(module_target_sat, module_org, module_location

@pytest.mark.parametrize('new_name', **parametrized(invalid_values_list()))
def test_negative_update_invalid_name(
request, module_target_sat, module_org, module_location, new_name
request, module_target_sat, module_org, module_location, new_name, libvirt
):
"""Attempt to update compute resource with invalid names

Expand All @@ -219,7 +222,7 @@ def test_negative_update_invalid_name(
"""
name = gen_string('alphanumeric')
compresource = module_target_sat.api.LibvirtComputeResource(
location=[module_location], name=name, organization=[module_org], url=LIBVIRT_URL
location=[module_location], name=name, organization=[module_org], url=libvirt.url
).create()
request.addfinalizer(compresource.delete)
compresource.name = new_name
Expand All @@ -228,7 +231,9 @@ def test_negative_update_invalid_name(
assert compresource.read().name == name


def test_negative_update_same_name(request, module_target_sat, module_org, module_location):
def test_negative_update_same_name(
request, module_target_sat, module_org, module_location, libvirt
):
"""Attempt to update a compute resource with already existing name

:id: 4d7c5eb0-b8cb-414f-aa10-fe464a164ab4
Expand All @@ -239,11 +244,11 @@ def test_negative_update_same_name(request, module_target_sat, module_org, modul
"""
name = gen_string('alphanumeric')
compresource = module_target_sat.api.LibvirtComputeResource(
location=[module_location], name=name, organization=[module_org], url=LIBVIRT_URL
location=[module_location], name=name, organization=[module_org], url=libvirt.url
).create()
request.addfinalizer(compresource.delete)
new_compresource = module_target_sat.api.LibvirtComputeResource(
location=[module_location], organization=[module_org], url=LIBVIRT_URL
location=[module_location], organization=[module_org], url=libvirt.url
).create()
request.addfinalizer(new_compresource.delete)
new_compresource.name = name
Expand All @@ -253,7 +258,7 @@ def test_negative_update_same_name(request, module_target_sat, module_org, modul


@pytest.mark.parametrize('url', **parametrized({'random': gen_string('alpha'), 'empty': ''}))
def test_negative_update_url(url, request, module_target_sat, module_org, module_location):
def test_negative_update_url(url, request, module_target_sat, module_org, module_location, libvirt):
"""Attempt to update a compute resource with invalid url

:id: b5256090-2ceb-4976-b54e-60d60419fe50
Expand All @@ -265,7 +270,7 @@ def test_negative_update_url(url, request, module_target_sat, module_org, module
:parametrized: yes
"""
compresource = module_target_sat.api.LibvirtComputeResource(
location=[module_location], organization=[module_org], url=LIBVIRT_URL
location=[module_location], organization=[module_org], url=libvirt.url
).create()
request.addfinalizer(compresource.delete)
compresource.url = url
Expand All @@ -279,9 +284,11 @@ def test_negative_update_url(url, request, module_target_sat, module_org, module
@pytest.mark.parametrize('setting_update', ['destroy_vm_on_host_delete=True'], indirect=True)
@pytest.mark.parametrize('pxe_loader', ['bios', 'uefi', 'secureboot'], indirect=True)
@pytest.mark.rhel_ver_list('[9, 10]')
@pytest.mark.parametrize('libvirt', ['libvirt9', 'libvirt10'], indirect=True)
def test_positive_provision_end_to_end(
request,
setting_update,
libvirt,
module_provisioning_rhel_content,
module_libvirt_provisioning_sat,
configure_secureboot_provisioning,
Expand Down Expand Up @@ -315,7 +322,7 @@ def test_positive_provision_end_to_end(
display_type='VNC',
organization=[module_sca_manifest_org],
location=[module_location],
url=LIBVIRT_URL,
url=libvirt.url,
).create()
request.addfinalizer(libvirt_cr.delete)
assert libvirt_cr.name == cr_name
Expand Down Expand Up @@ -358,7 +365,7 @@ def test_positive_provision_end_to_end(
assert host.name == f'{host_name}.{module_libvirt_provisioning_sat.domain.name}'
# Check on Libvirt, if VM exists
result = sat.execute(
f'su foreman -s /bin/bash -c "virsh -c {LIBVIRT_URL} list --state-running"'
f'su foreman -s /bin/bash -c "virsh -c {libvirt.url} list --state-running"'
)
assert host_name in result.stdout
# check the build status
Expand Down
Loading