[6.18.z] Fix AzureRM UI test host deletion assertion (#20466) #20573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix AzureRM UI test host deletion assertion --------- Co-authored-by: Arvind Jangir <[email protected]> (cherry picked from commit 7532ef3)
arvind4501
added
the
No-CherryPick
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The
wait_forconditionsession.host_new.search(fqdn)[0].get('Name') == 'No Results'can raiseIndexErrorif the search returns an empty list; consider making the polling condition resilient to both an empty result set and the 'No Results' row (e.g., inspecting the full list safely before indexing). - Instead of hardcoding the
'No Results'string in the assertion, consider using a constant or helper method from the page object layer (if available) so the test is less brittle to UI text changes.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `wait_for` condition `session.host_new.search(fqdn)[0].get('Name') == 'No Results'` can raise `IndexError` if the search returns an empty list; consider making the polling condition resilient to both an empty result set and the 'No Results' row (e.g., inspecting the full list safely before indexing).
- Instead of hardcoding the `'No Results'` string in the assertion, consider using a constant or helper method from the page object layer (if available) so the test is less brittle to UI text changes.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
Author
|
trigger: test-robottelo |
arvind4501
changed the title
Collaborator
|
PRT Result |
Satellite-QE
added
the
PRT-Failed
Contributor
Author
|
trigger: test-robottelo |
Collaborator
|
PRT Result |
Contributor
Author
|
trigger: test-robottelo |
Collaborator
|
PRT Result |
Satellite-QE
added
PRT-Passed
Gauravtalreja1
approved these changes
Dec 23, 2025
Gauravtalreja1
added
Failed_AutoCherryPick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 7532ef3)
Problem Statement
Solution
Related Issues