[6.18.z] Bump sphinx from 9.0.4 to 9.1.0 #20579
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit b71abc4)
Satellite-QE
added
6.18.z
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Since Sphinx 9.1.0 drops Python 3.11 and Docutils 0.20 support, double-check that the 6.18.z branch’s runtime/build environment (Python and docutils versions) is compatible with these new constraints to avoid breaking docs builds.
- Given the changes around HTMLThemeFactory and new add_static_dir() behavior in Sphinx 9.1.0, verify that any custom Sphinx extensions or theme hooks in this repo don’t rely on the previous HTML theme initialization or static asset handling APIs.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since Sphinx 9.1.0 drops Python 3.11 and Docutils 0.20 support, double-check that the 6.18.z branch’s runtime/build environment (Python and docutils versions) is compatible with these new constraints to avoid breaking docs builds.
- Given the changes around HTMLThemeFactory and new add_static_dir() behavior in Sphinx 9.1.0, verify that any custom Sphinx extensions or theme hooks in this repo don’t rely on the previous HTML theme initialization or static asset handling APIs.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
github-actions
bot
deleted the
cherry-pick-6.18.z-b71abc4c7c7a16791dcad17e74f45b9207da1b3e
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherrypick of PR: #20578
Bumps sphinx from 9.0.4 to 9.1.0.
Release notes
Sourced from sphinx's releases.
... (truncated)
Changelog
Sourced from sphinx's changelog.
Commits
cc7c6f4Bump to 9.1.0 finalb127b94Addapp.add_static_dir()for copying extension static files (#14219)20f1c46LaTeX: Inhibit breaks for rows with merged vertical cells (#14227)3c85411Polish CHANGES.rst (#14225)9ee5446LaTeX: restore 1.7 documentation of literalblockcappos (#14224)d75d602LaTeX: improve (again...) some code comments in time for 9.1.0 (#14222)8dca61dImprove some LaTeX code comments (#14220)8ab9600Bump to 9.1.0 candidate 2d59b237autodoc: Improve support for non-weakreferencable objects964424bUse the correct reference for using existing extensions (#14157)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)