Get backups working #113
Merged
Get backups working #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmeventd was added in a separate pr, and the system packages changes aren't actually needed. the samba tools can be added on systems that use them, and otherwise they aren't required for backups to work. i didn't find pve-qemu necessary to have in the system path.
nixpkgs automatically does the right thing since this is a basic autotools project.
|
Any chance of getting this merged? |
Closed
JulienMalka
approved these changes
Mar 3, 2025
Member
|
Thank you very much sorry for the delay in merging. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is built on the work done in #45, plus:
qmeventdchanges that aren't needed anymore/run/current-system/sw/lib, so it will be able to find the plugins for both VMs and LXC containerslxcto the path for vzdump, since it will now check the path for LXC tools since the LXC plugin is getting loadedzfsandbtrfs-progsto thepveschedulerservice path, similar to otherpve-managerservices. I found my scheduled jobs didn't work even though the ones triggered manually did, and it seems like this is why.