Skip to content

Revert "fix : 사진상세 하단 swiper가 pc에서도 잘 뜨게 수정" #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
caseBread merged 1 commit into from
Nov 28, 2025
Merged

Revert "fix : 사진상세 하단 swiper가 pc에서도 잘 뜨게 수정" #151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions src/feature/photo-detail/components/SwiperPhotoList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,15 +42,14 @@ export default function SwiperPhotoList({
return () => window.removeEventListener('resize', updateThumbOffset);
}, [updateThumbOffset]);

// TODO : activeIndex위치 구하는 로직 고도화 필요
// useEffect(() => {
// if (!thumbSwiper || thumbSwiper.destroyed) return;
useEffect(() => {
if (!thumbSwiper || thumbSwiper.destroyed) return;

// thumbSwiper.slideTo(activeIndex);
// requestAnimationFrame(() => {
// thumbSwiper.setTranslate(thumbOffset);
// });
// }, [activeIndex, thumbOffset, thumbSwiper]);
thumbSwiper.slideTo(activeIndex);
requestAnimationFrame(() => {
thumbSwiper.setTranslate(thumbOffset);
});
}, [activeIndex, thumbOffset, thumbSwiper]);

return (
<>
Expand Down Expand Up @@ -121,8 +120,9 @@ export default function SwiperPhotoList({
initialSlide={activeIndex}
slidesPerView='auto'
spaceBetween={2}
slidesOffsetBefore={thumbOffset}
slidesOffsetAfter={thumbOffset}
Comment on lines +123 to +124
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Using both slidesOffsetBefore/slidesOffsetAfter and programmatically calling thumbSwiper.setTranslate() in the useEffect hook seems redundant and may lead to conflicting behavior or visual glitches. The useEffect hook that calls setTranslate is designed to dynamically adjust the swiper's position, which is the correct approach for centering a dynamically selected active slide. The slidesOffset... props are generally for static offsets. Using a dynamic thumbOffset value here will cause the Swiper component to re-render whenever the active slide changes, which is less performant than just updating the transform via setTranslate.

It's recommended to remove slidesOffsetBefore and slidesOffsetAfter and rely solely on the useEffect to handle the translation.

watchSlidesProgress
centeredSlides
allowTouchMove={false}
className='custom-thumb-swiper relative w-full px-3 py-2 backdrop-blur-md'
>
Expand Down
Loading