Skip to content

PR 템플릿 수정 및 lint check actions 추가 #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
caseBread merged 9 commits into from
Oct 11, 2025
Merged

PR 템플릿 수정 및 lint check actions 추가 #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ba14323
feat : Pr 템플릿에 리뷰규칙 추가
caseBread Oct 8, 2025
1c05043
fix : PR템플릿 이름 수정
caseBread Oct 8, 2025
d32333b
fix : lint checker추가
caseBread Oct 8, 2025
d80ff91
fix : npm -> pnpm
caseBread Oct 8, 2025
508b899
fix : lint actions
caseBread Oct 8, 2025
230f50e
feat : pnpm설치
caseBread Oct 8, 2025
a7b57db
fix : pnpm cache제거
caseBread Oct 8, 2025
08e1d5f
fix
caseBread Oct 8, 2025
d016a3c
fix
caseBread Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .github/pull_request_templaye.md → .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,14 @@
## Reference

<!-- 참고한 사이트가 있다면 링크를 공유해주세요. -->

### 📜 리뷰 규칙

Reviewer는 아래 **P5 Rule**을 참고하여 리뷰를 진행합니다.
P5 Rule을 통해 Reviewer는 Reviewee에게 리뷰의 의도를 보다 정확히 전달할 수 있습니다.

- P1: 꼭 반영해주세요 (Comment)
- P2: 적극적으로 고려해주세요 (Comment)
- P3: 웬만하면 반영해 주세요 (Comment)
Comment on lines +33 to +35
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

P1-P3 규칙에 사용된 (Comment)라는 표현이 GitHub 리뷰 기능('Comment', 'Approve', 'Request changes')과 관련하여 혼동을 줄 수 있습니다. GitHub에서 'Comment'는 PR 병합을 막지 않는 중립적인 행동입니다.

만약 P1-P3 리뷰 의견이 병합 전에 수정이 필요한 변경 사항을 의미한다면, (변경 요청)과 같이 더 명확한 용어를 사용하는 것이 좋습니다. 이렇게 하면 리뷰어와 작성자 모두가 해당 코멘트에 대해 기대되는 조치를 명확히 이해하는 데 도움이 될 것입니다.

Suggested change
- P1: 꼭 반영해주세요 (Comment)
- P2: 적극적으로 고려해주세요 (Comment)
- P3: 웬만하면 반영해 주세요 (Comment)
- P1: 꼭 반영해주세요 (변경 요청)
- P2: 적극적으로 고려해주세요 (변경 요청)
- P3: 웬만하면 반영해 주세요 (변경 요청)

- P4: 반영해도 좋고 넘어가도 좋습니다 (Approve)
- P5: 그냥 사소한 의견입니다 (Approve)
33 changes: 33 additions & 0 deletions .github/workflows/lint-checker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
name: Lint Checker

on:
pull_request:
types: [opened, synchronize, reopened]

jobs:
lint:
runs-on: ubuntu-latest

steps:
- name: Checkout
uses: actions/checkout@v3

- name: Setup pnpm
uses: pnpm/action-setup@v4
with:
version: 7
run_install: false

- name: Setup Node
uses: actions/setup-node@v4
with:
node-version: 20

- name: Install pnpm
run: npm install -g pnpm

- name: Install deps
run: pnpm install

- name: Run lint
run: pnpm lint
Loading