Skip to content

fix: null issues when there are no existing comments #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: null issues when there are no existing comments #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e8cdfe6
fix null issues
Sep 18, 2023
c6c5dc9
Update code-coverage-assistant to use the latest ref for PRs.
Sep 18, 2023
c2da255
Update PR checks to use master branch of code-coverage-assistant.
Oct 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dist/main.js
View file
Open in desktop

Large diffs are not rendered by default.

86 changes: 47 additions & 39 deletions src/github.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,23 +15,27 @@
const appendHiddenHeaderToComment = (body, hiddenHeader) => hiddenHeader + body;

const listComments = async ({ client, context, prNumber, hiddenHeader }) => {
const { data: existingComments } = await client.issues.listComments({
...context.repo,
issue_number: prNumber,
});
const { data: existingComments } =
(await client.issues?.listComments({
...context.repo,
issue_number: prNumber,
})) || {};

return existingComments.filter(({ body }) => body.startsWith(hiddenHeader));
return (
existingComments?.filter(({ body }) => body.startsWith(hiddenHeader)) ??
[]
);
};

const insertComment = ({ client, context, prNumber, body }, hiddenHeader) =>
client.issues.createComment({
client.issues?.createComment({
...context.repo,
issue_number: prNumber,
body: appendHiddenHeaderToComment(body, hiddenHeader),
});

const updateComment = ({ client, context, body, commentId }, hiddenHeader) =>
client.issues.updateComment({
client.issues?.updateComment({
...context.repo,
comment_id: commentId,
body: appendHiddenHeaderToComment(body, hiddenHeader),
Expand All @@ -40,7 +44,7 @@ const updateComment = ({ client, context, body, commentId }, hiddenHeader) =>
const deleteComments = ({ client, context, comments }) =>
Promise.all(
comments.map(({ id }) =>
client.issues.deleteComment({
client.issues?.deleteComment({
...context.repo,
comment_id: id,
}),
Expand All @@ -54,37 +58,41 @@ export const upsertComment = async ({
body,
hiddenHeader,
}) => {
const existingComments = await listComments({
client,
context,
prNumber,
hiddenHeader,
});
const last = existingComments.pop();
if (client.issues) {
const existingComments = await listComments({
client,
context,
prNumber,
hiddenHeader,
});
const last = existingComments.pop();

await deleteComments({
client,
context,
comments: existingComments,
});
await deleteComments({
client,
context,
comments: existingComments,
});

return last
? updateComment(
{
client,
context,
body,
commentId: last.id,
},
hiddenHeader,
)
: insertComment(
{
client,
context,
prNumber,
body,
},
hiddenHeader,
);
}

return last
? updateComment(
{
client,
context,
body,
commentId: last.id,
},
hiddenHeader,
)
: insertComment(
{
client,
context,
prNumber,
body,
},
hiddenHeader,
);
return "";
};