fix: catch unknown id in router

Scalamando · Nov 18, 2021 · 613a43b · 613a43b
1 parent 2033ed2
commit 613a43b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/controllers/digit.controller.ts b/src/controllers/digit.controller.ts
@@ -45,11 +45,11 @@ export default class DigitController {
     }
 
     @Get("/:id/jpeg")
-    public async getDigitAsJpeg(@Path() id: string): Promise<Buffer> {
+    public async getDigitAsJpeg(@Path() id: string): Promise<Buffer | null> {
         const digit = await Repository.getDigit(Number(id));
 
         if (!digit) {
-            throw Error("No digit with this id");
+            return null;
         }
 
         return digit.image;

diff --git a/src/routes/digit.router.ts b/src/routes/digit.router.ts
@@ -38,6 +38,7 @@ router.get("/:id/jpeg", async (req: Request, res: Response) => {
     const controller = new DigitController();
     const response = await controller.getDigitAsJpeg(req.params.id);
 
+    if (!response) return res.status(404).send({ message: "No digit found" });
     res.type("image/jpeg").send(response);
 });