-
-
Notifications
You must be signed in to change notification settings - Fork 2k
use official cargo schema #5144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thanks for the PR! This section of the codebase is owned by @madskristensen and |
|
Thanks. I can merge once CI goes green ( |
c03affe to
514ac46
Compare
|
I check similar case
schemastore/src/api/json/catalog.json Line 6884 in b6a418e
https://github.com/SchemaStore/schemastore/tree/master/src/test Thus, should be OK to remove community schema |
|
I would like to confirm a few points of concern.
The advantage of using the official schema is that you automatically get the latest schema information. |
|
There are 35 Maybe contribute to official repo if description is not enough. Schemastore is using official docker compose schema. I don't know how It should be same. |
|
It would be better to delay the merge as the current official There is no clear ownership for who will contribute to the official schema. I will likely not be able to work on this issue for a while as my resources are diverted to another project 😓 You should probably think of |
|
Hi, @hyperupcall Has there ever been a similar situation for reference?
|
use official cargo schema
Related
Now upstream have official cargo schema
#5026
Notes
src/schemas/json/cargo.jsonand related test files are not yet removed