feat: support comments in .nvmrc files - #1492
Open
dbjorge wants to merge 2 commits into
Open
Conversation
Implements comment stripping for .nvmrc files following nvm v0.40.0 behavior. Comments (anything after #) are now stripped from .nvmrc files, supporting both inline comments and full-line comments. Leaves .node-version parsing as-is. Changes: - Add nvmrc.rs module for .nvmrc parsing with comment support - Refactor format detection to version_file_format.rs - Add unit tests for comment stripping and format detection - Add E2E tests for various comment scenarios Fixes: Schniz#1209
🦋 Changeset detectedLatest commit: 0b19a85 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@dbjorge is attempting to deploy a commit to the Gal Schlezinger's projects Team on Vercel. A member of the Team first needs to authorize it. |
dbjorge
marked this pull request as ready for review
January 15, 2026 00:09
|
I suggest validating test fixtures with https://npmjs.com/nvmrc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements comment stripping for .nvmrc files following nvm v0.40.0 behavior. Comments (anything after #) are now stripped from .nvmrc files, supporting both inline comments and full-line comments. Leaves .node-version parsing as-is.
Changes:
Fixes: #1209