Fix PowerShell PATH env output - #1572
Open
LingyeNBird wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$env:PATHat evaluation time.fnm env --shell powershellis generated.Problem
PowerShell currently receives a fully expanded PATH assignment from
fnm env. If a user copies the generated output into their PowerShell profile, that profile keeps a stale PATH snapshot. Later system or user PATH updates, such as installers adding new directories, are not picked up by that static snippet.The documented setup pipes
fnm envintoInvoke-Expression, but using a runtime$env:PATHreference makes the generated PowerShell snippet safer and consistent with the shell evaluating the current PATH when the snippet runs.Fix
Instead of generating:
PowerShell now generates:
This keeps fnm's path first while preserving the current PowerShell PATH at evaluation time.
Verification
$env:PATHat evaluation time, including throughOut-String | Invoke-Expression.cargo fmt --check.git diff --check.