Skip to content

Conversation

abdimo101
Copy link
Member

Description

In datasets.service.ts the metadata keys are now encoded before datasets gets created and updated.

Motivation

To ensure correct formatting of metadata key queries for both Elastic Search and MongoDB.

Fixes

  • Bug fixed (#X)

Changes:

  • changes made

Tests included

  • Included for each change/fix?
  • Passing?

Documentation

  • swagger documentation updated (required for API changes)
  • official documentation updated

official documentation info

@abdimo101 abdimo101 marked this pull request as ready for review July 31, 2025 12:29
@abdimo101 abdimo101 requested a review from Junjiequan July 31, 2025 12:29
@Junjiequan Junjiequan requested a review from nitrosx August 6, 2025 13:06
@Junjiequan
Copy link
Member

Junjiequan commented Aug 7, 2025

Can we create 2 utility functions for encode and decode that handles dot ?
Maybe call it like encodeURIComponentExtended or decodeURIComponentExtended
so that if we need to add more special characters in the future we don't have to change them from different places

@nitrosx
Copy link
Member

nitrosx commented Sep 2, 2025

We should also add testing for this feature

@abdimo101 abdimo101 requested a review from a team as a code owner September 24, 2025 14:43
@abdimo101 abdimo101 requested a review from nitrosx September 29, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants