-
Notifications
You must be signed in to change notification settings - Fork 32
feat: add scopes to v3 datasets #2237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: avoid_findone_dup
Are you sure you want to change the base?
Conversation
depends on #2236 and it's opened against that branch. Will rebase after merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO, using hardcoded "v3" and "v4" values in the functions calls will make the code less transparent, hard to manage and harder to separate by versions later on.
I would like to propose the creation of separated datasets.service.ts
for v3 and v4.
fine for me, so these services will then do the branching in your proposal? |
@minottic if I understand your question correctly, I would create a service v3 which will be used by the all the endpoints of dataset api v3 and a service v4 which will be used by all the dataset endpoints v4. |
ok, I will make a new commit for that |
Description
Reuse findOneComplete and findOneAll for v3 endpoints to enable scopes.
Motivation
Reintroduce loopback3 features to v3 endpoints (removing the support is non backward compatible change), by few findAllComplet branching
Changes:
Tests included
Documentation
official documentation info