fix: convert all object fields from obsolete to generic history #2288
+76
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omkar-ethz
commented
Oct 16, 2025
Comment on lines
+46
to
+49
| const { delta, originals } = computeDeltaWithOriginals(previousValue, { | ||
| ...previousValue, | ||
| ...currentValue, | ||
| }); |
There was a problem hiding this comment.
The rationale behind this logic is:
in the old backend's history (code), previousValue will contain datsetInstance[field], and currentValue will contain the fields to patch. computeDeltaWithOriginals expects both "complete" (oldObject, newObject). so we construct the newObject by overriding previousValue i.e. datsetInstance[field] with ...currentValue
minottic
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an inconsitency with #2286 - migrate all object-typed fields to the GenericHistory delta format, not just datasetlifecyle. Using
computeDeltaWithOriginalsof the history plugin to construct the deltas.Motivation
Fixes
Changes:
Tests included
Documentation
official documentation info