-
Notifications
You must be signed in to change notification settings - Fork 17
1101 Extend integrator classes and reimplement SDE models. #1296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1296 +/- ##
==========================================
+ Coverage 97.21% 97.29% +0.08%
==========================================
Files 167 169 +2
Lines 14960 14851 -109
==========================================
- Hits 14543 14449 -94
+ Misses 417 402 -15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@nijawa Could you double check that this PR solves the NaN issues (mathematically) correctly? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code is great :) Some comments. Some functions are short in/missing documentation. Also consider the readthedocs doc. However, it would make sense to update this in the branch there.
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
get_noise
.If need be, add additional information and what the reviewer should look out for in particular:
Order
template parameter, theget_noise
function and theXdeIntegrator
(maybe "DeIntegrator" or just "Integrator"?).Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)
Closes #1009
Closes #1101
Closes #1165
Closes #1218