-
Notifications
You must be signed in to change notification settings - Fork 17
1293 update secir groups surrogate models #1297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1297 +/- ##
==========================================
- Coverage 97.28% 97.27% -0.01%
==========================================
Files 168 171 +3
Lines 14858 15117 +259
==========================================
+ Hits 14454 14705 +251
- Misses 404 412 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…_groups/generate_dampings.py replaced by dampings.py
Inserting current main branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good :) Thank you!
Some comments. My main remark is that we should check the secir simple code again and outsource doubled code into an model independent directory/file (e.g. "utils").
Functions should only be stored in the correpsonding model files when they are strongly model dependent and not usable other otherwise :)
regarding the failing ci, you can just print the path, where the data is saved to. Then you see the correct one in the ci log.
pycode/memilio-surrogatemodel/memilio/surrogatemodel/ode_secir_groups/dampings.py
Outdated
Show resolved
Hide resolved
pycode/memilio-surrogatemodel/memilio/surrogatemodel/ode_secir_groups/dampings.py
Outdated
Show resolved
Hide resolved
pycode/memilio-surrogatemodel/memilio/surrogatemodel/ode_secir_groups/dampings.py
Outdated
Show resolved
Hide resolved
pycode/memilio-surrogatemodel/memilio/surrogatemodel/ode_secir_groups/dampings.py
Outdated
Show resolved
Hide resolved
pycode/memilio-surrogatemodel/memilio/surrogatemodel/ode_secir_groups/dampings.py
Outdated
Show resolved
Hide resolved
pycode/memilio-surrogatemodel/memilio/surrogatemodel/ode_secir_groups/data_generation.py
Outdated
Show resolved
Hide resolved
pycode/memilio-surrogatemodel/memilio/surrogatemodel/ode_secir_groups/model.py
Show resolved
Hide resolved
pycode/memilio-surrogatemodel/memilio/surrogatemodel/ode_secir_groups/model.py
Outdated
Show resolved
Hide resolved
pycode/memilio-surrogatemodel/memilio/surrogatemodel/ode_secir_groups/model.py
Outdated
Show resolved
Hide resolved
pycode/memilio-surrogatemodel/memilio/surrogatemodel/ode_secir_groups/model.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes :) It would be great if you could create a new test file that tests the utils. These should be model-independent. And therefore do not have to be tested within the model tests
pycode/memilio-surrogatemodel/memilio/surrogatemodel/utils/grid_search.py
Show resolved
Hide resolved
pycode/memilio-surrogatemodel/memilio/surrogatemodel/utils/helper_functions.py
Show resolved
Hide resolved
pycode/memilio-surrogatemodel/memilio/surrogatemodel/utils/helper_functions.py
Outdated
Show resolved
Hide resolved
pycode/memilio-surrogatemodel/memilio/surrogatemodel/utils/helper_functions.py
Outdated
Show resolved
Hide resolved
pycode/memilio-surrogatemodel/memilio/surrogatemodel/utils/helper_functions.py
Show resolved
Hide resolved
...e/memilio-surrogatemodel/memilio/surrogatemodel_test/test_surrogatemodel_ode_secir_groups.py
Outdated
Show resolved
Hide resolved
pycode/memilio-surrogatemodel/memilio/surrogatemodel/ode_secir_groups/data_generation.py
Show resolved
Hide resolved
pycode/memilio-surrogatemodel/memilio/surrogatemodel/ode_secir_groups/data_generation.py
Outdated
Show resolved
Hide resolved
pycode/memilio-surrogatemodel/memilio/surrogatemodel/utils/dampings.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only 1 minimal change left. Great work :)
pycode/memilio-surrogatemodel/memilio/surrogatemodel/ode_secir_groups/README.md
Outdated
Show resolved
Hide resolved
…_groups/README.md Co-authored-by: Henrik Zunker <[email protected]>
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
If need be, add additional information and what the reviewer should look out for in particular:
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)