refactor: improve BSplines with simpler parameterization#511
Open
sathvikbhagavan wants to merge 11 commits into
Open
refactor: improve BSplines with simpler parameterization#511sathvikbhagavan wants to merge 11 commits into
sathvikbhagavan wants to merge 11 commits into
Conversation
sathvikbhagavan
force-pushed
the
sb/bsplines
branch
from
April 24, 2026 13:59
d32a570 to
ff221ee
Compare
sathvikbhagavan
force-pushed
the
sb/bsplines
branch
from
May 7, 2026 08:23
ff221ee to
334da61
Compare
sathvikbhagavan
force-pushed
the
sb/bsplines
branch
from
July 9, 2026 22:21
a1e9536 to
f93f657
Compare
sathvikbhagavan
force-pushed
the
sb/bsplines
branch
from
July 21, 2026 15:16
66a10aa to
50633ed
Compare
sathvikbhagavan
marked this pull request as ready for review
July 22, 2026 16:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simplifies BSplines. There is no need to have intermediate parameterization p ∈ [0,1] and a piecewise-linear mapping t → p, which is designed for 2D/3D parametric curves, not function interpolation.