Make GenericLUFactorization bypass overloads when used on DualLinear Problems
#685
+24
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be better to opt out instead of opt in. A way to do this is to make |
jClugstor
changed the title
GenericLUFactorization bypass overloads when used on DualLinear Problems
| @@ -87,13 +87,6 @@ backslash_x_p = A \ new_b | |||
| @test ≈(x_p, backslash_x_p, rtol = 1e-9) | |||
|
|
|||
| # Nested Duals | |||
| function h(p) | |||
There was a problem hiding this comment.
It was a duplicate definition, it's first defined up above.
|
Looks like some precompilation issues are happening? I can't seem to replicate the failures locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Needed so that GenericalLUFactorization on DualLinearProblems can go through the normal init.
It's a little bit clunky but I don't think there's another way to exclude specific algorithms from going through the Dual version of
init. Plus this way is explicit about exactly which algorithms will go through the Dual overloads.