Skip to content

Conversation

DhairyaLGandhi
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

cc @SebastianM-C can you check if this is sufficient for your use cases, and we can add a test then

Add any other context about the problem here.

@ChrisRackauckas
Copy link
Member

We should make sure this gets appropriately tested in SciMLSensitivity too.

@SebastianM-C
Copy link
Contributor

yeah, it seems to work for me (on a simple example at least)

@SebastianM-C
Copy link
Contributor

Btw, I noticed that subset_tunables does not remove Initials. Does this affect the performance or it's not an issue?

@ChrisRackauckas
Copy link
Member

That will not effect the performance of adjoints much, but it will forward mode

@AayushSabharwal
Copy link
Member

Initials are not tunables. Why exactly do we need this?

@SebastianM-C
Copy link
Contributor

I'm not sure if we need this or not, I just noticed that Initials show up in tunable_parameters(sys).

@AayushSabharwal
Copy link
Member

Oh, that's a lie. I'm pretty sure when I added initials and the initial_parameters = true keyword, I just did a find-replace of all parameters(sys) to parameters(sys; initial_parameters = true). This is probably a remnant of that.

@DhairyaLGandhi
Copy link
Member Author

Does that mean this can be closed since it won't be actionable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants