Merge pull request #355 from lxvm/patch-1

Update vector_of_array.jl
SciML · Feb 27, 2024 · 8b7627f · 8b7627f
2 parents e00bdb2 + d06b8a6
commit 8b7627f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/src/vector_of_array.jl b/src/vector_of_array.jl
@@ -304,6 +304,11 @@ Base.@propagate_inbounds function _getindex(A::AbstractVectorOfArray{T, N},
     return Adapt.adapt(__parameterless_type(T),
         reshape(reduce(hcat, vecs), size(A.u[1])..., length(A.u)))
 end
+Base.@propagate_inbounds function _getindex(A::AbstractVectorOfArray{T, N},
+    ::NotSymbolic, I::Colon...) where {T <: Number, N}
+    @assert length(I) == ndims(A.u)
+    return A.u[I...]
+end
 
 Base.@propagate_inbounds function _getindex(A::AbstractVectorOfArray{T, N},
         ::NotSymbolic, I::AbstractArray{Bool},

diff --git a/test/basic_indexing.jl b/test/basic_indexing.jl
@@ -257,3 +257,6 @@ foo!(u_vector)
 # test efficiency 
 num_allocs = @allocations foo!(u_matrix)
 @test num_allocs == 0
+
+# issue 354
+@test VectorOfArray(ones(1))[:] == ones(1)