Fix recursivecopy for VectorOfArray with immutable outer storage - #636
Merged
ChrisRackauckas merged 1 commit intoJul 24, 2026
Conversation
When the outer container is immutable (e.g. SVector of arrays), `b.u .= recursivecopy.(a.u)` fails because setindex! is undefined. Rebuild via rewrap, matching Base.zero, so recursivecopy deep-copies and preserves the outer type. Fixes the remaining failure path for SciML/OrdinaryDiffEq.jl#1365. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
recursivecopy(::AbstractVectorOfArray)previously didb.u .= recursivecopy.(a.u). That fails when the outer container is immutable (e.g.SVectorof arrays) becausesetindex!is undefined onSVector.When the outer storage is immutable, rebuild via
rewrap(same pattern asBase.zero), so the deep copy preserves the outer type and does not share inner arrays.This is the remaining failure for OrdinaryDiffEq.jl#1365 after
zero.(Q)already preservedSVectorouter storage.Test plan
recursivecopy(VectorOfArray(SVector{2}([randn(5), randn(5)])))preserves type, deep-copies innersVectorpath still deep-copiesThis PR should be ignored until reviewed by @ChrisRackauckas.