Remove NLsolve dependency in favor of SimpleNonlinearSolve #644
+24
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the direct NLsolve.jl dependency with SimpleNonlinearSolve.jl for the IIF methods (IIF1M, IIF2M, IIF1Mil). This follows the same approach taken in OrdinaryDiffEq.jl (PR #2081). Changes: - Remove NLsolve from dependencies and compat - Add SimpleNonlinearSolve to dependencies and compat - Update NLSOLVEJL_SETUP to use SimpleTrustRegion instead of NLsolve.nlsolve - Replace OnceDifferentiable wrapper with a simple function wrapper The implicit methods that use OrdinaryDiffEqNonlinearSolve (ImplicitEM, ISSEM, SKenCarp, etc.) are unaffected as they already use NonlinearSolve internally. Closes SciML#642 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Member
|
@ChrisRackauckas CI doesn't look too good but can we tag a new release nevertheless? Or are any test failures related to the change here? |
Member
|
yeah the test failure is unrelated to this. I know what it is and need to get to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the direct NLsolve.jl dependency and replaces it with SimpleNonlinearSolve.jl, similar to what was done in OrdinaryDiffEq.jl (PR #2081).
Changes:
NLsolvefrom dependencies and compatSimpleNonlinearSolveto dependencies and compatNLSOLVEJL_SETUPto useSimpleTrustRegioninstead ofNLsolve.nlsolveOnceDifferentiablewrapper with a simple function wrapper that works with SimpleNonlinearSolveAffected methods:
OrdinaryDiffEqNonlinearSolvewhich uses NonlinearSolve internallyTest plan
Closes #642
🤖 Generated with Claude Code