Skip to content

Removes IO modules from Daru #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
athityakumar wants to merge 13 commits into
base: v-1-pre
Choose a base branch
from
Open

Removes IO modules from Daru #430

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
68016eb
Removes all IO methods and tests except save, load, to_html
athityakumar Sep 1, 2017
79a3f8d
Removes unnecessary fixture files
athityakumar Sep 1, 2017
b716d51
Resolves merge conflict with origin:master
athityakumar Oct 10, 2017
ba318be
Shifts remaining marshal and save methods to dataframe, vector and index
athityakumar Oct 10, 2017
e130ab5
Removes require of daru/io/io.rb
athityakumar Oct 10, 2017
9b62bfd
Merge branch 'v-1-pre' into remove-io-modules
athityakumar Oct 10, 2017
1e2187c
Makes few changes to reduce rspec error
athityakumar Oct 10, 2017
a0224f5
Retains 2 csv files in spec/fixtures/ for tests
athityakumar Oct 10, 2017
d3762cb
Adds one final change for passing RSpec
athityakumar Oct 10, 2017
ea3f747
Removes Marshal methods
athityakumar Oct 15, 2017
f8e7c1f
Merges with origin/v-1-pre
athityakumar Oct 15, 2017
dafa586
Adds daru-io as runtime dependency of daru
athityakumar Oct 15, 2017
37a1dc5
Reverts the dependency on daru-io (to be changed pre-release)
athityakumar Oct 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
source 'https://rubygems.org'
gemspec
gem 'daru-io', :git => 'https://github.com/athityakumar/daru-io.git'
1 change: 1 addition & 0 deletions daru.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ Gem::Specification.new do |spec|
spec.required_ruby_version = '>= 2.1.0'

spec.add_runtime_dependency 'backports'
spec.add_runtime_dependency 'daru-io'
Copy link
Member Author

@athityakumar athityakumar Oct 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zverok - daru-io and daru are both runtime_dependencies of each other, and that's creating an infinite loop in travis builds while bundle installing. :trollface:

Copy link
Collaborator

@zverok zverok Oct 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, already thought of that. I believe that daru should be development dependency of daru-io (meaning since "daru 1.0" there is no sense in installing daru-io by itself, as it is installed with daru)

Copy link
Member Author

@athityakumar athityakumar Oct 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, should v0.1.1 be released for daru-io with this dependency change?

Copy link
Collaborator

@zverok zverok Oct 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably so. At the same time when daru-1.0.0-pre would be released, probably?..

Copy link
Collaborator

@zverok zverok Oct 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, but this way we can't continue developing daru in this branch :philosoraptor:
OK, let's leave this branch with development dependency on daru-io, and then change that on release.

Copy link
Member Author

@athityakumar athityakumar Oct 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acknowledged. Let me just add daru-io to the Gemfile rather than then gemspec, so that it doesn't interfere with travis CI builds. Before daru-1.0.0-pre release, this can be changed after daru-io-0.1.1 releases. Can you add this into the milestone?


# it is required by NMatrix, yet we want to specify clearly which minimal version is OK
spec.add_runtime_dependency 'packable', '~> 1.3.9'
Expand Down