Skip to content

Also convert attribute units when calling convert_units #6416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bouweandela
Copy link
Member

🚀 Pull Request

Description

Also convert the attributes "actual_range", "valid_max", "valid_min", and "valid_range" on cubes and coordinates.

Closes #6411


Consult Iris pull request check list


Add any of the below labels to trigger actions on this PR:

  • benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts

@bouweandela bouweandela force-pushed the fix-convert-units-valid-minmax branch from 1ca463b to 38ab31c Compare April 23, 2025 11:06
@bouweandela bouweandela force-pushed the fix-convert-units-valid-minmax branch from 38ab31c to 28dfd25 Compare April 23, 2025 11:15
Copy link

codecov bot commented Apr 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.80%. Comparing base (7fd73e8) to head (28dfd25).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6416   +/-   ##
=======================================
  Coverage   89.80%   89.80%           
=======================================
  Files          90       90           
  Lines       23752    23758    +6     
  Branches     4418     4422    +4     
=======================================
+ Hits        21331    21337    +6     
  Misses       1672     1672           
  Partials      749      749           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bouweandela bouweandela marked this pull request as ready for review April 23, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

convert_units does not convert valid_min/valid_max
1 participant