-
Notifications
You must be signed in to change notification settings - Fork 12
Drop support for old python, Fix style according to pylint update #843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #843 +/- ##
==========================================
+ Coverage 57.62% 59.85% +2.23%
==========================================
Files 64 64
Lines 3686 3687 +1
==========================================
+ Hits 2124 2207 +83
+ Misses 1562 1480 -82 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@rv0lt There should only be one label. Either |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure there are things in the workflows that we need to change? E.g. that we have a pylint for these Python versions I believe
Co-authored-by: Ina Odén Österbo <[email protected]>
back to draft until the pylint issue is fix |
I am not sure which label would fit this case @i-oden |
Pull Request Template
Before Marking as Ready for Review
dev
(or other targeted branch)SPRINTLOG.md
if neededIf the target branch is
master
:Summary
Following the updates for packages for security. We need to drop support for old python versions, as they have reached their end of life, future security updates will not be done for these versions. And packages updates can broke DDS for old python versions. -> https://devguide.python.org/versions/
This update also means updating Pylint, as the support for the new python versions is not included in 2.X.X
Bumping pylint implied new rules that we need to adapt the code. From this new rules, there is one that limits to 5 the number of arguments in a function. We need to disable it as it will mean heavy code changes.
Related Issue/Ticket
Link GitHub issue or provide Jira ID.
Testing
If applicable: How did you verify the change? Include commands, data, or screenshots.
Reviewer Notes
Anything that helps reviewers (e.g. areas needing close attention).
Once all boxes are checked, mark the PR as Ready for Review and tag at least one team member as the initial reviewer.