Skip to content

Conversation

rv0lt
Copy link
Member

@rv0lt rv0lt commented Sep 9, 2025

Pull Request Template

Before Marking as Ready for Review

  • Add relevant information to the sections below (Summary etc)
  • Rebase or merge the latest dev (or other targeted branch)
  • Update documentation if needed
  • Add an entry to the SPRINTLOG.md if needed
  • Choose an appropriate label. See here for information on the labelling options
  • The code follows the style guidelines
  • Perform a self-review: read the diff as if reviewing someone else's code
  • I have commented the code, particularly in hard-to-understand areas
  • Verify that all checks and tests have passed

If the target branch is master:

Summary

  • Following the updates for packages for security. We need to drop support for old python versions, as they have reached their end of life, future security updates will not be done for these versions. And packages updates can broke DDS for old python versions. -> https://devguide.python.org/versions/

  • This update also means updating Pylint, as the support for the new python versions is not included in 2.X.X

  • Bumping pylint implied new rules that we need to adapt the code. From this new rules, there is one that limits to 5 the number of arguments in a function. We need to disable it as it will mean heavy code changes.

Related Issue/Ticket

Link GitHub issue or provide Jira ID.

Testing

If applicable: How did you verify the change? Include commands, data, or screenshots.

Reviewer Notes

Anything that helps reviewers (e.g. areas needing close attention).


Once all boxes are checked, mark the PR as Ready for Review and tag at least one team member as the initial reviewer.

@rv0lt rv0lt self-assigned this Sep 9, 2025
@rv0lt rv0lt added type: docs Improvements or additions to documentation cli type: dependency For release template labels Sep 9, 2025
Copy link

codecov bot commented Sep 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.85%. Comparing base (37b5c97) to head (157b46a).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #843      +/-   ##
==========================================
+ Coverage   57.62%   59.85%   +2.23%     
==========================================
  Files          64       64              
  Lines        3686     3687       +1     
==========================================
+ Hits         2124     2207      +83     
+ Misses       1562     1480      -82     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@i-oden
Copy link
Member

i-oden commented Sep 9, 2025

@rv0lt There should only be one label. Either type: docs or type: dependency

@rv0lt rv0lt removed the type: dependency For release template label Sep 9, 2025
@rv0lt rv0lt marked this pull request as ready for review September 9, 2025 12:10
@rv0lt rv0lt requested a review from a team as a code owner September 9, 2025 12:10
Copy link
Member

@i-oden i-oden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure there are things in the workflows that we need to change? E.g. that we have a pylint for these Python versions I believe

@rv0lt rv0lt marked this pull request as draft September 10, 2025 11:19
@rv0lt
Copy link
Member Author

rv0lt commented Sep 10, 2025

back to draft until the pylint issue is fix

@rv0lt rv0lt changed the title Drop support python 3.8 and 3.9 Fix style according to guidelines and drop support python 3.8 and 3.9 Sep 11, 2025
@rv0lt rv0lt changed the title Fix style according to guidelines and drop support python 3.8 and 3.9 Fix style according to guidelines and drop support for old python versions Sep 11, 2025
@rv0lt
Copy link
Member Author

rv0lt commented Sep 11, 2025

I am not sure which label would fit this case @i-oden

@rv0lt rv0lt changed the title Fix style according to guidelines and drop support for old python versions Drop support for old python, Fix style according to pylint update Sep 18, 2025
@rv0lt rv0lt marked this pull request as ready for review September 18, 2025 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli type: docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants